mff-uk / odcs

ODCleanStore
1 stars 11 forks source link

Get rid of the full user name validation or create more meaningful one #1247

Closed ghost closed 10 years ago

ghost commented 10 years ago

Well, will this project be used only be european people? See this:

Pattern namePattern1 =  Pattern.compile("([A-Za-zŽžÝýŮůÚúŤťŠšŘřÓóŇňÍíĚěÉéĎďČčÁáÄäÖößÜüÀàÈèÙùÂâÊêÎîÔôÛûÇçËëÏïÜüŸÿ]+\\s*)+", Pattern.UNICODE_CASE);
                    Matcher m = namePattern1.matcher(inputFullName);
                    if (!m.matches()) {
                        ex = new InvalidValueException("Full user name must start with a letter and can only consists of letters and spaces.");
                        throw ex;
                    }

What about Chinese? Yiddish? etc

tomas-knap commented 10 years ago

Yes, there is no big reason to restrict the user name, data is considered as UTF-8

ghost commented 10 years ago

Resolved here: https://github.com/UnifiedViews/Core/commit/dd9be90a8e5648ace63a5c542daf8d4573e1da76