mfherbst / ReducedBasis.jl

Reduced basis methods for parametrised eigenproblems
https://mfherbst.github.io/ReducedBasis.jl/stable/
MIT License
14 stars 0 forks source link

Improve state of docs #36

Closed pbrehmer closed 1 year ago

pbrehmer commented 1 year ago

There are a few things, that could be improved and added:

mfherbst commented 1 year ago

I also have some feedback we could talk about.

Most importantly I feel you are assuming people read the docs from front to back, but spoiler: They won't. Make sure each docs page is self-contained or directly references a page where the basic aspect you are building on is explained. In particular don't hide code. Some people will just copy and paste and walk away frustrated if it does not just work.

pbrehmer commented 1 year ago

Yes that's a very good point. The point of hiding code was to show that only certain steps in the offline phase have to be changed to customize the solver etc., while all of the online procedure stays the same.

Now with Literate I won't hide any code and just remark on the bits that previous examples have already covered, to highlight this.

pbrehmer commented 1 year ago

PR #37 fixed most of these things. What's left to do is:

And additionally to get the docs to a good "preliminary state":