search

mfikes / ambly

ClojureScript REPL into embedded JavaScriptCore
http://ambly.fikesfarm.com
Eclipse Public License 1.0
541 stars 21 forks source link

How to stop the WebDav server sonner after JSContext is no longer valid #108

Closed zwang closed 8 years ago

zwang commented 8 years ago

My use case is that after I am done with one JSContext, I will exit a view and de-reference the JSContext, ABYServer by setting them nil. I found that the WebDav server still can be connected but when I connect, it will trigger a EXC_BAD_ACCESS error shown below: screen shot 2015-11-24 at 5 52 44 pm

Can I stop the WebDav server as soon as the socket connection is not usable?

mfikes commented 8 years ago

@zwang I suppose Ambly currently has no shutdown lifecycle methods, but it could use them. Happy to take a PR (Ambly is under a CA). Otherwise maybe I can add some lifecycle methods.

zwang commented 8 years ago

@mfikes I see. I will take a look this week then. Will sign the CA later. Thank you. :)

mfikes commented 8 years ago

https://github.com/omcljs/ambly/commit/e8f69492f187da970b686963266f828c4dd6908b