mfikes / ambly

ClojureScript REPL into embedded JavaScriptCore
http://ambly.fikesfarm.com
Eclipse Public License 1.0
541 stars 21 forks source link

Make the amblyRequire function name be upper case #59

Closed mfikes closed 9 years ago

mfikes commented 9 years ago

Recently, I made AMBLY_PRINT_FN be upper case because I wanted it to follow the theme of CLOSURE_IMPORT_SCRIPT (a globally accessible fn that you don't want to collide, prefixed with the name of the entity specifying the fn).

We could end up where the Ambly native hooks, like AMBLY_PRINT_FN and amblyRequire are well-known (public API?)

For example if you (enable-console-print!) then the only way to get printing back to your REPL is currently (set-print-fn! js/AMBLY_PRINT_FN).

For consistency amblyRequire should be named something like AMBLY_IMPORT_SCRIPT or AMBLY_REQUIRE.