mfikes / esprit

ClojureScript on the ESP32 using Espruino
Eclipse Public License 2.0
138 stars 13 forks source link

Fixes error on `undefined` in variadic args - improves CIDER patch #26

Closed kiranshila closed 4 years ago

kiranshila commented 4 years ago

This is an Espruino bug: https://github.com/espruino/Espruino/issues/1691

This fix patches every instance of arguments with [x=arguments,x][1] where x is some hopefully non-conflicting random name.

Unfortunately, this increases the binary size quite a bit, by about 100K. But, now that we have 3MB, it should be OK.

Additionally, I moved the CIDER fix to the client-side repl code to avoid doing big string operations on device, this gave a major performance boost.