search

mfinzi / equivariant-MLP

A library for programmatically generating equivariant layers through constraint solving
MIT License
251 stars 21 forks source link

olive oil dependencies #12

Closed whitead closed 2 years ago

whitead commented 2 years ago

olive-oil-ml depends on pytorch, torchvision, and sklearn which makes the emlp install download about 1GB of packages even though it's a small package. Is there anyway to reduce the dependencies in olive oil, like by adding optional dependencies? Thanks!

mfinzi commented 2 years ago

This is a good point. We essentially only use olive-oil-ml for the experiments and datasets, so it should be possible to make it an optional dependency with some care. I will try to do that this weekend.

mfinzi commented 2 years ago

Hi Andrew, I just merged this change onto master and the new v1.0.1 pypi release removes the olive-oil-ml requirement. 👍

whitead commented 2 years ago

Thanks for taking care of this!