search

mfld-fr / emu86

Intel IA16 emulator for embedded development
35 stars 6 forks source link

rom-pcxtat: fix buggy keyboard peek logic. #62

Closed cocus closed 3 years ago

cocus commented 3 years ago

If there was a previously peek character, use that one instead of asking the console to poll for a new key press.

cocus commented 3 years ago

From the s80x86 project, I came to the conclusion that this can be improved even further by using the keyboard buffer on the BDA. Let's have it as this for now, which does not use the BDA for buffering the last key pressed

mfld-fr commented 3 years ago

I spotted the bug after your first report about this problem in https://github.com/mfld-fr/emu86/issues/30#issuecomment-834870241, by commenting the function with a FIXME, but I had no time yet to do the fix. So thank you for your help !

mfld-fr commented 3 years ago

Just one minor thing : when committing, please insert an empty line between the title of the commit and its body, to avoid a too long text in the summarized commit list (like f55a38f). Thanks !

cocus commented 3 years ago

Yeah, sorry, I usually do that and I forgot.