Allow SHIFT-Mouse1 drag to select to "select partial tall"

[mfn]

Actually 1.5 behavior

[Hipshot-zz]

1.5 seems to use SHIFT-MOUSE1, not only MOUSE1.

[mfn]

Yeah, I got that wrong when writing the messages too, I always meant with SHIFT, sorry for the confusion and thanks for correcting me.

[mfn]

I've an experimental version up in http://github.com/mfn/GtkRadiant/tree/rectangle . No binaries though.

It implements "select parial tall" on shift-mouse1 and draws a white rectangle. It's very related to issue 22, thus the rectangle has been enabled for "select complete tall" for alt-mouse1 as well.

There's a small visual glitch when rendering the rectangle, albeit that "it works" for me.

[AEonZR]

I am not seeing the render glitch... and Shift+LMB-drag seems to work in XY View, but in Camera View there seem to be some issues:

• With e.g. 3 brushes in the Camera View does not automatically select the first brush under the mouse in Shift+LMB-drag but does actually nothing, keeping up the dragging the paint select mode does not work at all.
• When you explicitly select Shift+LMB-click one brush and then perform a Shift+LMB-drag, only then does the paint select mode actually work.
• On the other hand Alt+LMB-drag in XY View works as expected, letting you select completely "covered" brushes. But when you finish dragging and Alt+LMB-click your previous selection is gone (deselected). IMO, that behavior is logical, technically you did a zero size "Alt+drag-select", covering nothing, thus the deselect. But again, it is unexpected to have anything actually deselect your selections, other than explicitly hitting the Esc-key, IMO.
• Alt+LMB-drag in Camera View does nothing... and it shouldn't, right?

[mfn]

Thanks for the feedback; I didn't really test 3D mode; I didn't expected it to change existing behavior either, will look into it.

The ALT-LMB behavior is untouched; so what you see with de-select predates my changes and is 1.6 behavior. Do you suggest to change that?

Btw, to I interpret it correctly that, for the 3D view, Shift-LBM-drag and paint select mode actually conflict?

[AEonZR]

On changes concerning Alt+LMB-drag... I'll need to do more testing with v1.4 and v1.5 to see how the normally react... never used this "feature" before... I just mentioned it because it surprised me a bit.

...3D view, Shift-LBM-drag and paint select mode actually conflict?

Yes indeed... paint select in 3D view is technically broken...

[0bsidian]

Here is a complete selection controls comparison between GtkRadiant 1.5 and 1.6 (using default 1.4 settings), as well as my recommendations. This should help consolidate the selection controls between both 1.5 and 1.4 while keeping both paint select and drag select tall features.

http://robotrenegade.com/temp/radiant16/gtkradiant-selection-controls-comparison.png

[AEonZR]

I think we all should double-check 0bsidians table very carefully... some of those shortcuts even I after years was not aware of... and I have the feeling that some of the suggested deprecations are actually features I have been using since v1.2.13. Will do some testing on this...

[0bsidian]

Perhaps it will be a bit of a compromise between 1.4 and 1.5 users, but I think it mixes the best of both worlds and the only thing I totally got rid of was some of the redundant features while retaining both paint and drag select features. Why would you need a feature to select specifically just one face when you have another one that will allow you to select one or more faces? Silly Radiant.