search

mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
90 stars 35 forks source link

Request Support PlaceholderAPI or API-Improvement #11

Closed GeertBraakman closed 5 years ago

GeertBraakman commented 5 years ago

Issue

Hello, I would like to request a feature for your plugin, I'm creating a settings menu for my server and I would like to add an option in there to toggle chestsorting, but I can't check if the player has ChestSorting enabled or not, I can do that by a placeholder with the PlaceholderAPI, but your plugin doesn't support it. So i tried to make my own placeholder but i got the problem that the methode i need to use is package private in your plugin.

Solution

So my question was, can you add support for the PlaceholderAPI or just make the methode sortingEnabled(Player p) public so I can acces it with the API for your plugin.

thank you in advance, Geert Braakman Administator/Developer on LuminexMC

mfnalex commented 5 years ago

Of course, that's a great suggestion. This will be added shortly. Thanks

mfnalex commented 5 years ago

The method is now public and documented here: https://github.com/JEFF-Media-GbR/Spigot-ChestSort/blob/master/HOW_TO_USE_API.md

mfnalex commented 5 years ago

I hope this change suits your needs. I have never used PlaceholderAPI so if you could create a pull request for adding placeholders, that would be awesome.