mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

Unable to open hotkey menu with chestsort.use.inventory without chestsort.use #117

Open FirstL1ght opened 3 years ago

FirstL1ght commented 3 years ago

Used ChestSort version 10.2.1, 10.3.0

Used Spigot version git-Tuinity-"3eda860" (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

Describe the bug I wanted to make all players can use inventory sort, but only privileged players can use chest sort.

I gave the default group chestsort.use.inventory privilege only and in version 10.2.1 it worked, but the hotkey settings menu could not be opened without chestsort.use (I'm sorry, but you do not have permission to perform this command...).

I downloaded version 10.3.0 code and built it. Now sorting by hotkeys does not work at all when I am not op.

To Reproduce Described everything in Describe the bug

Expected behavior Users with the chestsort.use.inventory privilege are expected to be able to sort only inventory, while users with chestsort.use can sort both inventory and chests. Important: The hotkey configuration menu must be able to open with any privilege (chestsort.use.inventory or chestsort.use).

But actually, in that case, it would be better to make two different privileges. For example chestsort.sortinventory and chestsort.sortchest. And if player has any of them, they can open the hotkeys menu.

Additional context I used default config.

mfnalex commented 3 years ago

Actually chestsort.use is the base permission. I'll change it so that the hotkeys can be changed when either of the two permissions is given.