search

mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
90 stars 34 forks source link

AdvancedChests hook bug fixed! #149

Closed DeadSilenceIV closed 2 years ago

DeadSilenceIV commented 2 years ago

Hello i just wanted to fix a small bug related to the hook of my plugin AdvancedChests.

mfnalex commented 2 years ago

Thanks, will merge tomorrow (still on vacation)

mfnalex commented 2 years ago

Is the check whether AE is installed not needed? Oh and what was the bug? I need to know for the changelog :)

DeadSilenceIV commented 2 years ago
  1. Yes, the verification is still required.
  2. The thing is that previously i was using a method that gets the AdvancedChests if the passed inventory is part of the chest, however, since i only want the main inventory of the chest(The ChestPage class) to be sorted, i added an extra check to see if the passed inventory is a ChestPage and not another sub-inventory of the chest.
DeadSilenceIV commented 2 years ago

Hello, it seems that the fix of this problem haven't been posted correctly on the lastest spigot update because the jar seems to contain the old code, i would really appreciate if you could verify this thanks.

mfnalex commented 2 years ago

whoops sorry, no idea how that could have happened. will reupload it now