mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
90 stars 35 forks source link

Sorting not permanent #26

Closed FatalBlade closed 5 years ago

FatalBlade commented 5 years ago

Used version Click-Sort update

Describe the bug When sorting an inventory or chest the sorting does not persist through closing and reopening.

To Reproduce Fill an inventory or chest with random items then sort it with a middle click, After that close then reopen the inventory or chest.

Expected behavior Items to remain sorted.

Additional context I'm using both LWC and Residence in my server, however, I have reproduced this both inside and outside a residence and with or without LWC protection on a chest.

I had thought that this happened with the command to auto sort chests as well but it appears that if auto sort is on it attempts to sort then fails.

The command /invsort Does work properly.

mfnalex commented 5 years ago

I cannot reproduce the error, however I will investigate this further. Have you tried ChestSort without other plugins?

FatalBlade commented 5 years ago

No I haven't yet, I may not be able to do that for a few days but I will let you know as soon as I'm able,

FatalBlade commented 5 years ago

Hmmmm. I just had a chance to get one of my players to test this problem for me as well. It seems they were able to do it just fine. I was opped when the issue occurred so it may have something to do with conflicting permissions from another plug?

mfnalex commented 5 years ago

I don't know, actually the hotkeys do nothing more than just calling the regular ChestSort API to have the inventory sorted. That means: if it has been sorted, it should stay sorted. I suggest you just keep an eye on it and tell me when you have problems again :)

FatalBlade commented 5 years ago

I think I figured it out, I have another sorting plugin that adds the ability to AutoRefill your hotbar and to Unload all your items into nearby chests with a command. The sorting aspects I have removed by default by denying permissions but when opped they're all given so that was the problem. Sorry for the confusion I'm closing the Issue.

mfnalex commented 5 years ago

No problem! By the way, I also have a plugin for unloading your items into nearby chests, called InvUnload :)

FatalBlade commented 5 years ago

No problem! By the way, I also have a plugin for unloading your items into nearby chests, called InvUnload :)

I saw that but it looked like it wasn't quite uploaded to 1.14.3? Or that there was some issue with unloading the hotbar as well? I actually have that set to watching on spigot and was waiting for an update so that I could add that and get rid of the other one. (assuming that autofill was added)

mfnalex commented 5 years ago

I have just tested it with 1.14.3 and everything seems to work as intended. The auto fill feature will be added in a few days, since I just added CrackShot support I need a break now :D

FatalBlade commented 5 years ago

Alright cool, I'll add InvUnload in the next few days here and see how it works out.