search

mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

Sandstone, Red Sandstone and more, not found in category files? #4

Closed JoshuaJoppie closed 5 years ago

JoshuaJoppie commented 5 years ago

I am using 1.13.2 server. 3.2 update.

Am I missing something here? am I blind to it? you have "*_stone..." but sandstone is one word without an underscore, so it isn't included properly.

mfnalex commented 5 years ago

I must have forgotton that. I will change it soon.

JoshuaJoppie commented 5 years ago

I actually went through and there are MANY items not found in the categories. Like certain ore, and such.

I would give your categories another run through to make sure they are all correct.

Reason why this is so important, is because if it's not in a category, it moves it to the bottom of the chest.

On Wed, Dec 5, 2018, 2:35 AM JEFF <notifications@github.com wrote:

I must have forgotton that. I will change it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JEFF-Media-GbR/Spigot-ChestSort/issues/4#issuecomment-444387604, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxxkLjC3-tRPlfEPo2G_v9pKApBI7lrks5u13c5gaJpZM4Y_ewf .

mfnalex commented 5 years ago

I have written the category files as an example. If there are things missing, I will happily add the missing items, however I don't have much time and this is a very minor issue, so: feel free to make a pull request. If you don't want to create a pull request, just upload the files after you have added the missing items and I will change it in the repo.

mfnalex commented 5 years ago

Here is a dump of ALL existing materials with their current default category: https://api.jeff-media.de/chestsort/category-dump-5-dec-2018.txt

JoshuaJoppie commented 5 years ago

That's perfect! I'll update that list asap

On Wed, Dec 5, 2018, 6:37 AM JEFF <notifications@github.com wrote:

Here is a dump of ALL existing materials with their current default category: https://api.jeff-media.de/chestsort/category-dump-5-dec-2018.txt

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JEFF-Media-GbR/Spigot-ChestSort/issues/4#issuecomment-444455552, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxxkE_gJUtqk2iYiuoOUTewVQK4yWxKks5u16_3gaJpZM4Y_ewf .

mfnalex commented 5 years ago

Thank you, that's awesome! :)

mfnalex commented 5 years ago

Anything new regarding the list?