search

mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

Added Hopper, Enderchest and Minecart to sortable Inventories #48

Closed mindsolve closed 4 years ago

mindsolve commented 4 years ago

Dear maintainers,

I have noticed that some trivial inventory types/block types are not sortable, like Enderchests, Hoppers and Chests in Minecarts.

After some testing with the changed whitelist (in belongsToChestLikeBlock), I found no issues with sorting in them. I would appreciate you considering this PR and whether it fits in with your idea/motivation.

Thank you, MindSolve

P.S.: I tested the code changes on a PaperMC 1.15.2 (Spigot fork) MP server only, but I think there should be no differences between CraftBukkit/Spigot/Paper in my changes.

mfnalex commented 4 years ago

Thank you! I will merge this after I tested everything, however I am currently not working on ChestSort. If you are interested in becoming a maintainer, please message me at mail at jeff-media.de

mfnalex commented 4 years ago

Sorting hoppers could destroy item sorters like those: https://minecraft.gamepedia.com/Tutorials/Hopper#Item_sorter

The other additions sound good, update will be released in a few days

mfnalex commented 4 years ago

Will merge now but I'm gonna remove the hoppers for now because of the mentioned problem. Thank you very much.