mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

Custom GUI Issue #57

Closed Makkief closed 4 years ago

Makkief commented 4 years ago

I can sort custom GUIs and take Items from there when using hotkeys. Is it possible to detect custom GUIs?

mfnalex commented 4 years ago

That depends on which plugin's GUI you are using. Can you please tell me the plugins?

Makkief commented 4 years ago

Dynamic Shop... etc Hmm... isn't possible to check if inventory is just normal chest placed on ground?

mfnalex commented 4 years ago

I will have a look, thank you for the report

mfnalex commented 4 years ago

This does only happen for the two new shortcuts (left-/right-click outside inventory), right?

Makkief commented 4 years ago

No all the hotkeys work on custom GUI

mfnalex commented 4 years ago

No all the hotkeys work on custom GUI

Well I just tried it with Dynamic Shop ( https://www.spigotmc.org/resources/ss-dynamic-shop-1-13-1-15-2.65603/ ) and it only worked with the new hotkeys. I will have a look again

mfnalex commented 4 years ago

Please try again using the latest 8.3 version

Makkief commented 4 years ago

I guess the new feature works fine thanks I will let you know if there is a problem.

Makkief commented 4 years ago

Have you tested Inventory Pages recently?

Makkief commented 4 years ago

hook-inventorypages: true

I set this true but It takes InventoryPages button from my inventory.

mfnalex commented 4 years ago

Thanks, I will fix this

mfnalex commented 4 years ago

Fixed in c17fd9dc5a2e6bc34d8bae217a89aa583f468e2f

mfnalex commented 4 years ago

Please check and tell me if it now works as expected :) Sorry for the trouble, I totally forgot that I wrote an extra hook for InventoryPages.

Most 3rd party plugins should not cause any problems, but if they do, please open a new issue :)

Makkief commented 4 years ago

not fixed yet. It still takes InventoryPages's buttons from my inventory and put them to the chest.

mfnalex commented 4 years ago

Are you using the latest version?

mfnalex commented 4 years ago

Fixed in e2e05c0c3fd06a3f381223a5ac13a61079aeef89