search

mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

Merge into shulker on manual sort #79

Closed MattAKAFred closed 3 years ago

MattAKAFred commented 4 years ago

Implemented the basic functionality for moving items in a sorted inventory into shulker boxes within that inventory when manually (hotkey) sorting.

Doing the same on autosorting using the condenseIntoShulkers function should be easy to implement if desired

Probably needs a permission node/check

Also, open to suggestions for better handling Shulker Packs if sorting player inventory while Shulker Pack is open - currently it just closes the inventory window, because if you don't, items added to or removed from Shulker Pack will be deleted/duplicated respectfully. Ideally, I think it would be nice to open the player's personal inventory window, but I'm yet to figure out how to do that from the server side.

mfnalex commented 4 years ago

Thanks for the PR, however I am not really sure if most players would want this. I would probably get many bug reports "OMG my items are gone wtf 1/5 stars fuck this author" :/

MattAKAFred commented 4 years ago

What about placing it behind a setting that defaults to off? Let users choose to activate it and require the permissions chestsort.shulker or something like that? Happy to revise the PR to include some settings.

mfnalex commented 4 years ago

Yes, that's a good idea.

mfnalex commented 3 years ago

Thanks for the PR and sorry for the extremely late reply, but we decided that this is not something that ChestSort should do, as it's only designed to sort inventories, and nothing else.