mfnalex / ChestSort

Best sorting plugin for Minecraft / Spigot 1.14+
https://www.chestsort.de
GNU General Public License v3.0
91 stars 34 forks source link

support for "Custom Enderchest" #80

Closed AcesGamingUK closed 4 years ago

AcesGamingUK commented 4 years ago

Is your feature request related to a problem? Please describe.

Cant seem to get the plugin to work with Custom EnderChest

Describe the solution you'd like

Potentially have full implementation

mfnalex commented 4 years ago

What doesnt work?

AcesGamingUK commented 4 years ago

oh my bad, I can't get any of the click functions to work

mfnalex commented 4 years ago

Okay, I can fix this, but it requires changes in the Custom Enderchest plugin. I will create a pull request and if the author accepts, I can add support for the next version.

mfnalex commented 4 years ago

This is the line that prevents ChestSort from sorting CustomEnderChests: https://github.com/JEFF-Media-GbR/Spigot-ChestSort/blob/master/src/main/java/de/jeff_media/ChestSort/ChestSortListener.java#L337

I will have a look at this the next days to see what I can do. Unfortunately CustomEnderChests doesn't use maven so it's a mess to work on.

AcesGamingUK commented 4 years ago

ok thank you for looking, it's honestly no big deal, was just something I noticed :)

mfnalex commented 4 years ago

I have asked the author to make a small change to his plugin so I can add support easily :) https://github.com/brunyman/CustomEnderChest/issues/13

mfnalex commented 4 years ago

I have added support for ChestSort to CustomEnderChest ( https://github.com/brunyman/CustomEnderChest/pull/14/commits/3066904f9782a9767af48f08bab1c5f84a97c78a ). If the author does not accept my Pull request in time, feel free to join my discord ( https://discord.com/invite/Jckqsa4 ) so I can send you the CustomEnderChest.jar file