search

mfnalex / InvUnload

Spigot plugin that automatically puts your stuff into the right chests
GNU General Public License v3.0
6 stars 8 forks source link

search message shows `%s` when no chest is near #33

Open taupemoi opened 4 years ago

taupemoi commented 4 years ago

When no chest is near, the search error message is incorrect, for example:

search bone returns Could not find any chests containing %s

If a chest (without bone) is nearby, it correctly returns: Could not find any chests containing BONE.

Relatedly, if it's not too complicated, adding a separate error message when there are no chests at all (There are no chests within radius ...) could be more informative for the user.

Finally, since search uses the same default radius as all other commands, the documentation should maybe add that one can override that radius by specifying it as a 3rd argument, e.g. search bone [RADIUS]. Maybe having a user command to change the default radius on a per-user base could be useful as well?

mfnalex commented 4 years ago

Thanks, will be fixed

hippotastic commented 3 years ago

I just encountered the same issue (the search command literally outputs "Could not find any chests containing %s." without %s being replaced), so carefully nagging @mfnalex to fix this. 😄

mfnalex commented 3 years ago

oh wut? Did I not fix that? It's been quite a time since your issue lol

mfnalex commented 3 years ago

Fixed in 4.10.3 :)

mfnalex commented 3 years ago

Sorry for the delay, I totally forgot this issue!

mfnalex commented 3 years ago

Reopening this issue for the other suggestions mentioned in the first post

hippotastic commented 3 years ago

You could maybe update the issue title to reflect what's still left to do. Maybe something like this:

/search: new message if no chests are within radius, add optional radius argument