Open TheMatheusDev opened 2 years ago
Hi, for us PRs always welcome! If you are interested to implement this feature to InvUnload, we would like to review your PR :)
If i don't hear news from you, i will have a look
I tried renaming the "blacklist-title" to "message-blacklist-title" but that didn't worked. Looks like changes on source code needs to be done. I took a look on Messages.java file but unfortunately i don't have the java knowledge to update and build the plugin to test myself.
The easiest (and also laziest) way make it work, it's to use the actual "blacklist-title" variable. I don't think this alternative is the best because the config option doesn't have the "message-" prefix and doesn't follow the pattern of the others blacklist messages, such as "message-blacklist-removed", "message-blacklist-invalid"...
What do you think?
@Cazcez Do something useful and create a Pull Request :P
Otherwise I'll do it when I have time :)
That was a quick reply! xD
Thanks for hearing my suggestion and sorry for not being able to do it by myself. Cheers!
Intro:
Hi, your plugins are great, I can't play my survival server without them anymore, they have such great utilities. Thanks. To make InvUnload even more good, you could make "blacklist-title" (line 229) of the "config.yml" file translatable to other languages, as the other messages already are.
Pros & Cons:
Pros:
Cons:
In-game example:
Below is a in-game example on a scenario with a portuguese translation containing the inconsistency : ("Blacklist" should be "Lista Negra")
How should be:
Original line 229:
Add something like #message-blacklist-title:
Conclusion:
This implementation can be easily done. Waiting for your answer to open a pull request with a new translation! 😉