search

mfnalex / Spigot-UpdateChecker

UpdateChecker for your Spigot plugins with only one line of code needed in your plugin!
GNU General Public License v3.0
54 stars 14 forks source link

Fix not using Strings for id #33

Closed CJCrafter closed 10 months ago

CJCrafter commented 10 months ago

It seems that you used to use an int parameter when initializing an UpdateChecker, but not anymore. The README.md still uses an int in the example. This PR just switches those to Strings.

For example, in this deprecated method, you call String.valueOf(int) so you can call the method; passing the int does not work. https://github.com/mfnalex/Spigot-UpdateChecker/blob/master/src/main/java/com/jeff_media/updatechecker/UpdateChecker.java#L226

I also made sure to check the other methods to ensure they had ints:

  1. https://github.com/mfnalex/Spigot-UpdateChecker/blob/master/src/main/java/com/jeff_media/updatechecker/UpdateChecker.java#L815

  2. https://github.com/mfnalex/Spigot-UpdateChecker/blob/master/src/main/java/com/jeff_media/updatechecker/UpdateChecker.java#L854

    Thanks, CJCrafter

mfnalex commented 10 months ago

Thx!