search

mfogel / django-simple-email-confirmation

Simple email confirmation for django.
170 stars 68 forks source link

Fix for Django 2.0 #44

Closed wlonk closed 6 years ago

wlonk commented 6 years ago

Just involved adding a value for on_delete.

Here's a cute animal picture for you:

bison

mdamien commented 6 years ago

Very cute ! Tests are failing for an unrelated reason (python3.5 not found) but I'm gonna fix that, thanks for the PR !

wlonk commented 6 years ago

Thanks. I tested it locally with 3.5.2 and it worked, for what it's worth.

mdamien commented 6 years ago

I also detected via your PR that the lib installed Django 2.0 even if the python version is 2.7 (which crash of course)

This is gonna happen in a lot of unpinned libraries deps, details in cb79aae

wlonk commented 6 years ago

Ach, good catch, thank you.