search

mfogel / django-simple-email-confirmation

Simple email confirmation for django.
170 stars 68 forks source link

Fix EmailAddress.is_primary #49

Closed ferndot closed 6 years ago

ferndot commented 6 years ago

The current code does not reference a variable that exists.

ferndot commented 6 years ago

@mfogel this completely breaks the is_primary field. Can we merge and release this swiftly please?

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.578% when pulling 99dfd39a50b841f65c52ef90e2ab122702cda9c7 on joshua-s:patch-1 into 90a1c90abd41760b0f9645c78987ab6c0bfd1ada on mfogel:develop.

mdamien commented 6 years ago

Update incoming :) thanks !

EDIT: Released as 0.4, if you have time, would be also cool to have a test for this codepath

ferndot commented 6 years ago

Thanks @mdamien! That is a very good idea and I will look into it.