search

mfogel / django-simple-email-confirmation

Simple email confirmation for django.
170 stars 68 forks source link

Support Django Rest Framework #55

Open ferndot opened 5 years ago

ferndot commented 5 years ago

I extended this package to support Django Rest Framework for a personal project. This is a functionality that is not supported by any other email verification package for Django (that I have found).

Would there be interest in merging this into this package (like what django-filter does). Or, should I create a separate package to bolt on the functionality?

jakeharding commented 5 years ago

I'm also using this on a DRF project, and I'm very interested to see how you extended this package! Can you share a link to a diff?

ferndot commented 5 years ago

Here you go: https://gist.github.com/joshua-s/8938f7ab66d5f38f6f9449ea86e1c871

jakeharding commented 5 years ago

Thanks! I like this idea, and I would likely use this. Would it make DRF and templated_mail upstream dependencies?

ferndot commented 5 years ago

The email solution is up for discussion (we don't need to use templated_mail). IIRC we could include DRF as only a dev dependency and then conditionally import it if the user wants to enable the DRF functionality. If that doesn't work, we will probably need to make this a separate package.

ferndot commented 5 years ago

I am revisiting this and hoping to open a PR

joshuakoh1 commented 4 years ago

Will this be implemented?

Myzel394 commented 2 years ago

@joshua-s , @joshuakoh1 , @jakeharding lol you all start with "j" :O Sorry for breaking your names, but maybe someone could take a look again after over two years? :(

ferndot commented 2 years ago

@Myzel394 hey! I am so sorry for this delay. I had implemented this feature for a past project, but hit some blockers when attempting to genericize it and add it to this library. I should have communicated more on this issue.

I can't make any promises, but if I have some free time, I may go back and try to put something up for you.