mfoltz / Bloodcraft

GNU Affero General Public License v3.0
13 stars 3 forks source link

quest target by name #39

Closed archenovalis closed 2 months ago

archenovalis commented 2 months ago

After displaying the target's level, I found that sometimes quest target wouldn't update when killing Cultists. I believe all cultists are the same level but some have different guid.

mfoltz commented 2 months ago

Would rather not provide quest credit based on generalized unit name. In general I'm unlikely to accept pull requests unless it's something we've discussed prior but will review the level display changes.

archenovalis commented 2 months ago

No worries about accepting them. I'm just sending code that shows how I worked around the issue

On Sat, Sep 14, 2024, 13:58 zfolmt @.***> wrote:

Would rather not provide quest credit based on generalized unit name. In general I'm unlikely to accept pull requests unless it's something we've discussed prior but will review the level display changes.

— Reply to this email directly, view it on GitHub https://github.com/mfoltz/Bloodcraft/pull/39#issuecomment-2351128997, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBW5QQF2UUBN2ISQ67H55OTZWSIO7AVCNFSM6AAAAABOHDM5EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGEZDQOJZG4 . You are receiving this because you authored the thread.Message ID: @.***>