mfontanini / cppkafka

Modern C++ Apache Kafka client library (wrapper for librdkafka)
BSD 2-Clause "Simplified" License
600 stars 206 forks source link

Removed dependency from rdkafka since it has its own pkg_config file.… #199

Closed accelerated closed 5 years ago

accelerated commented 5 years ago

Description

accelerated commented 5 years ago

Done. Btw, for the versioning, perhaps you can bump to 1.0.0 since the sonames are not really matching. Also any plans to finish the admin API?

mfontanini commented 5 years ago

Thanks! What do you mean the sonames aren't matching?

I have a separate branch on the admin API stuff but I honestly don't have the time (or the willingness) to finish it now. It's actually mostly done I think. I was just missing something to encapsulate the message responses. Maybe I'll push myself to finish it some day soon.

accelerated commented 5 years ago

Thanks! What do you mean the sonames aren't matching?

Sorry i meant the .so versions. Since your version was already tagged in github at a higher number (0.3.x) but your cmake was still building with 0.2

accelerated commented 5 years ago

I might give it a go to complete the admin API since we will most likely need it in the near future.

mfontanini commented 5 years ago

I already went back and fixed the sonames in 0.3.0 and 0.3.1, that was very broken.

I might give it a go to complete the admin API since we will most likely need it in the near future.

Sounds good! Please let me know (comment on #119) when you do so we don't overlap in case I actually start working on it.

accelerated commented 5 years ago

sure