mfontanini / cppkafka

Modern C++ Apache Kafka client library (wrapper for librdkafka)
BSD 2-Clause "Simplified" License
600 stars 206 forks source link

Fix tracker promise from throwing when set multiple times #235

Closed accelerated closed 4 years ago

accelerated commented 4 years ago

Two issues:

@mfontanini please prioritize this if you can. Much appreciated!!

accelerated commented 4 years ago

Yes it has gotten a bit out of hand with too many features instead of keeping a strict delineation of functionality and split it into smaller classes. The class API however is quite clean so that's always good. I may revisit the inner implementation the future or perhaps bring back the original design under some other name and keep this one as-is (if you want). Not too many use it so hopefully it's not causing instability elsewhere. I think however that admin API would have higher priority as future work.

mfontanini commented 4 years ago

Yeah, the admin API should be the next thing although I probably won't for on that in the near future.