search

mfontanini / cppkafka

Modern C++ Apache Kafka client library (wrapper for librdkafka)
BSD 2-Clause "Simplified" License
600 stars 206 forks source link

Try to fix travis #248

Closed filimonov closed 4 years ago

filimonov commented 4 years ago

Old URL returns 404, picked new from official webpage: https://kafka.apache.org/downloads

filimonov commented 4 years ago

@accelerated do you know smth about why the travis tests fail with the newest librdkafka?

accelerated commented 4 years ago

Looks to me like a race condition in the compacted processor and it gets stuck. Unfortunately I dont have access to Travis to restart the builds since i'm not the repo owner

mfontanini commented 4 years ago

Restarted the build but the same thing is probably going to happen.

mfontanini commented 4 years ago

Yeah, this is hanging on the new kafka version. Can you remove the new broker version in the travis matrix? We should figure out what's up with that test but that can wait.

filimonov commented 4 years ago

Let's try a bit older version first...

filimonov commented 4 years ago

v1.3.0 is failing too...

filimonov commented 4 years ago

So the problem started with v1.0.0

stevenylai commented 4 years ago

The test is stuck when the consumer is trying to wait for eof for all partitions. I briefly tested with the new library, we need to first set: "enable.partition.eof": true, and second, rdkafka only returns eof to those are assigned to the consumer. I will try to open a PR and see if it fixes this

mfontanini commented 4 years ago

Thanks for the fix!