search

mfontanini / cppkafka

Modern C++ Apache Kafka client library (wrapper for librdkafka)
BSD 2-Clause "Simplified" License
600 stars 206 forks source link

Fix tests #251

Closed stevenylai closed 3 years ago

stevenylai commented 4 years ago

This should fix https://github.com/mfontanini/cppkafka/issues/249

I also added NODE_ID Macro so that I can use my existing cluster to run those tests

It should be based on the other travis pull request but I don't think I can merge from one fork to another.

jlcordeiro commented 3 years ago

I had the same problems whilst running the tests and these changes did indeed fix them. PR build seems to be failing but at first glance it was a temporary issue (?)

jlcordeiro commented 3 years ago

@stevenylai did a few extra tests and everything build fine to me. I'd suggest maybe closing / reopening PR to see if we get all checks passing before suggesting a merge onto master.

stevenylai commented 3 years ago

@jlcordeiro Yes, I wanted to check this but always forgot afterwards. Let me see if I can update the branch to trigger a re-build

stevenylai commented 3 years ago

I see the current master is already passing travis build so I guess there is nothing to be fixed then. Closing.