Currently, I am making some performance tests in this project and, while doing so, I ran into following lines of code in libtins/tests/active_tests/include/active_test_runner.h:
I think they are not safe because they would create memory leak. The documentation says that if an exception is thrown, the call to emplace has no effect - which means the plain pointer we have passed in is never deleted.
Therefore, I would suggest changing lines above to something like this:
Hi there,
Currently, I am making some performance tests in this project and, while doing so, I ran into following lines of code in
libtins/tests/active_tests/include/active_test_runner.h
:I think they are not safe because they would create memory leak. The documentation says that if an exception is thrown, the call to emplace has no effect - which means the plain pointer we have passed in is never deleted.
Therefore, I would suggest changing lines above to something like this:
What do you think? PR is made with this fix.