mfontanini / libtins

High-level, multiplatform C++ network packet sniffing and crafting library.
http://libtins.github.io/
BSD 2-Clause "Simplified" License
1.89k stars 373 forks source link

Replace remaining `rfind_pdu` calls to `find_pdu` in `src` directory #527

Closed jamestiotio closed 3 months ago

jamestiotio commented 4 months ago

This commit replaces the remaining rfind_pdu calls to find_pdu in the src directory. Any existing rfind_pdu calls in the examples and tests directories are unmodified.

The main motivation is that conditional statements are generally more performant than exception handling. Since rfind_pdu calls find_pdu internally anyway, this eliminates some overhead as well.

mfontanini commented 3 months ago

Thanks!