`config.yaml` file is ignored on Windows

mfontanini / presenterm

A markdown terminal slideshow tool

https://mfontanini.github.io/presenterm/

BSD 2-Clause "Simplified" License

1.19k stars 29 forks source link

`config.yaml` file is ignored on Windows #180

Closed nagromc closed 7 months ago

nagromc commented 7 months ago

The config.yaml file is ignored on Windows unless I set the HOME environment variable to %USERPROFILE%. %APPDATA% should be preferred on Windows though.

Using the directories crate may help to load platform-specific paths (%APPDATA% on Windows for example).

presenterm v0.5.0

mfontanini commented 7 months ago

What's the exact path you would expect it to be in Windows? %APPDATA%/presenterm/config.yaml?

nagromc commented 7 months ago

Well, it’s up to your implementation, actually.

I think we should respect platform-specific paths:

on Windows: %APPDATA%/presenterm/config.yaml (will point to %USERPROFILE%/AppData/Roaming/presenterm/config.yaml)
on Linux: ~/.config/presenterm/config.yaml
on macOS: ~/Library/notSureOfThisPart/presenterm/config.yaml

Or, if you want to keep it simple, ~/.config/presenterm/config.yaml on every platform.

mfontanini commented 7 months ago

Thanks for the report! I verified this works as expected in windows (see PR for paths) but feel free to double check.

nagromc commented 7 months ago

It works as expected on Windows on my side. Thanks!