search

mfontanini / presenterm

A markdown terminal slideshow tool
https://mfontanini.github.io/presenterm/
BSD 2-Clause "Simplified" License
1.33k stars 32 forks source link

ci: cargo clippy checks all targets for errors #234

Closed mikavilpas closed 5 months ago

mikavilpas commented 7 months ago

This is a continuation of https://github.com/mfontanini/presenterm/pull/231 and should help in keeping all targets linted in the future. That PR only fixed the current situation - this one should make sure things stay clean in the future as well.

mfontanini commented 7 months ago

It's actually complaining about an import with this change, can you address that one? Thanks!

mikavilpas commented 7 months ago

Yes, I'm actually just looking into it. I don't seem to be able to reproduce the error locally.

I wonder if CI uses a different version of the toolchain or clippy, or something. I can of course remove the error manually, but it might be annoying to keep CI happy in the future if the errors can't be seen locally.

@mfontanini would you have time to check if cargo clippy --all-targets -- -D warnings reports any errors for you?

mfontanini commented 7 months ago

I don't see it locally. The problem is the CI is using the latest version of rust (which is a bad idea) so it will complain about things you may not see locally. If you rustup update you should see it.

But also this should use a pinned version of rust in the CI, otherwise this can happen. I was going to do that at some point but never did, maybe it's time.

mfontanini commented 5 months ago

Closing as these should be fixed.