mfontanini / presenterm

A markdown terminal slideshow tool
https://mfontanini.github.io/presenterm/
BSD 2-Clause "Simplified" License
1.19k stars 29 forks source link

fix: support mmdc on windows #319

Closed bbawj closed 1 month ago

bbawj commented 1 month ago

I am not sure if Windows platform support is of any importance but I encountered an issue where mmdc cannot be found on Windows. This is due to this issue where Command::new() on Windows works in this way: "if the file has a different extension, a filename including the extension needs to be provided, otherwise the file won’t be found.".

Since mmdc on Windows is an alias for the mmdc.cmd script and not an exe, this updates the name used to find the mmdc tool.

mfontanini commented 1 month ago

I am not sure if Windows platform support is of any importance

It is, I just didn't test this properly over there. I assumed since things like invoking cargo or other tools work this would work too but I guess not. Thanks!

mfontanini commented 1 month ago

Looks like you need to run cargo fmt for the CI to pass.

mfontanini commented 1 month ago

Thanks again!