search

mfornet / acmx

Competitive programming made simple. VSCode extension.
MIT License
148 stars 9 forks source link

Resolve #139: added an autoOpen option #140

Closed ftiasch closed 2 years ago

ftiasch commented 2 years ago

It seems that package.json configures a run test path prefix with out/ while tsconfig.json says that the outDir should be dist/....

I fixed the test command and now the tests run smoothly on my machine.

mfornet commented 2 years ago

@ftiasch the PR works; but I wonder if it solves your particular problem. I was expecting you to download the problem to the current working directory; otherwise it will be downloaded to the usual place and you will have no feedback of it being downloaded at all; and you will need to manually open the specific folder where it was downloaded.

Is this the expected behaviour?

mfornet commented 2 years ago

Fixes #139

ftiasch commented 2 years ago

@ftiasch the PR works; but I wonder if it solves your particular problem. I was expecting you to download the problem to the current working directory; otherwise it will be downloaded to the usual place and you will have no feedback of it being downloaded at all; and you will need to manually open the specific folder where it was downloaded.

Is this the expected behaviour?

Yes! Usually, I have a VSCode workspace running which contains some workspace-specified settings & extensions. In particular, the acmx extension is enabled in this workspace. Let's say my workspace already opened the folder SOLVING_PATH.Then, I use the CompetitiveCompanion to download tasks and tests to the folder SOLVING_PATH.

Without this PR, the SOLVING_PATH folder is automatically opened, replacing my nicely configured workspace, which is undesired for me. Thus, I simply add an option to disable such behavior.