Incorrect transmission curve?

mfouesneau / pyphot

suite to deal with passband photometry

https://mfouesneau.github.io/pyphot/

MIT License

57 stars 18 forks source link

Incorrect transmission curve? #17

Closed jvines closed 4 years ago

jvines commented 5 years ago

Hi,

I was working with pyphot and I found that when plotting the transmission curve for GROUND_JOHNSON_B I get the following:

download

which is obviously incorrect.

Cheers,

Jose V.

mfouesneau commented 4 years ago

I get the right passband

f = pyphot.get_library()['GROUND_JOHNSON_B'] plt.plot(f.wavelength, f.transmit)

It seems you have the wrong x-values

jvines commented 4 years ago

The issue is not the x-axis but the y-axis. The passband should be a number between 0 and 1. I'm not sure you account for that in your package when applying the transmission filter - especially because this is the only passband filter that's shown like this. All others that I have used are restricted to [0, 1]