Closed christophra closed 1 year ago
I now found out about pyphot.sandbox
and its parallel Unit
classes. The bug seems to be fixed in UnitFilter.from_ascii
, i.e. when using pyphot.sandbox.UnitAscii_Library
in the example above.
Yes, I need to deprecate the old classes.
I'm sorry the title is a bit vague, I was trying to cover two possibilities because I'm not sure about the expected behaviour. The docs say
So if I understand that right, the issue is either
from_ascii
makes/(AB|ST|Vega)_zero_Jy/
inversely proportional to the transmission curve normalization" Interestingly, the one quantity in photons (mentioned above) which is meant to change only changes by a rounding error, along with the other Vega system zero points.I understand this doesn't have high priority because
_zero_flux
and_zero_mag
are the ones used for flux/magnitude calculations. But maybe it's still helpful to report.Steps to reproduce:
libs/ascii_sources
withAscii_Library
get_library
to loadlibs/new_filters.hdf5
Expected behaviour: Their zero points (etc.) are identical within rounding error.
Observed behaviour:
AB_zero_Jy
,ST_zero_Jy
,Vega_zero_Jy
are reduced by a factor 100Minimal example