search

mfp / ocaml-sqlexpr

Minimalistic syntax extension for type-safe, convenient execution of SQL statements.
Other
86 stars 17 forks source link

Remove estring dependency #37

Open Chris00 opened 5 years ago

Chris00 commented 5 years ago

estring may soon not be maitained anymore. May you update your code to remove its dependency? Thanks.

mfp commented 5 years ago

On Mon, Nov 05, 2018 at 04:16:35PM -0800, Christophe Troestler wrote:

estring may soon not be maitained anymore. May you update your code to remove its dependency? Thanks.

As of ocaml-sqlexpr 0.9.0, estring is used as an optional dependency by the camlp4 extension provided for backwards compatibility; it is not a hard dependency and thus ocaml-sqlexpr is installable on OCaml >= 4.06 (which defaults to -safe-string, that breaks estring's build) even though estring isn't.

I believe the proper "fix" is to update estring's opam file to signal it is not installable on >= 4.06.

-- Mauricio Fernández