search

mfp / ocaml-sqlexpr

Minimalistic syntax extension for type-safe, convenient execution of SQL statements.
Other
86 stars 17 forks source link

Replace deprecated ppx_core with ppxlib #41

Open Lupus opened 5 years ago

Lupus commented 5 years ago

This PR tries to fix issue #40.

copy commented 5 years ago

This fix works for me.

adrien-n commented 4 years ago

I'm not able to upgrade to ocaml 4.08 with sqlexpr installed despite this patch. I'm not familiar with opam packaging or ppx but I'm under the impression the issue is that the dependencies in the .opam file(s) are not changed by this PR.

adrien-n commented 4 years ago

Looking at this again, that comment from me is wrong. That being said, src/OMakefile is not updated by this PR and probably needs the same change.

And I think the opam issue is rather that opam keeps the same dependencies even though the pin should change them.

adrien-n commented 4 years ago

OK, this was caused by opam itself and upgrading it from 2.0.0 to 2.0.5 fixed my issue.

edit: that and/or not pinning all the packages of the repo; sorry for the noise.