search

mfp / oraft

Raft consensus algorithm implementation
Other
32 stars 5 forks source link

Fix compilation and switch to `dune`, `logs`, `cmdliner` #6

Closed vbmithr closed 6 years ago

vbmithr commented 6 years ago

Ok this should be good. The last patch contains logs and cmdliner combined. I tried to segment patches intelligently but I changed so many things that this cut in two patches did more sense in the end.

Hope this is good now!

mfp commented 6 years ago

On Thu, Oct 11, 2018 at 01:39:54AM -0700, Vincent Bernardoff wrote:

Ok this should be good. The last patch contains logs and cmdliner combined. I tried to segment patches intelligently but I changed so many things that this cut in two patches did more sense in the end.

Looks good to me, merging.

In order to test it with the OPAM 1.2 setup I had handy, I had to change lang-dune to 1.2 (since 1.3 is only available in the OPAM 2 repos), which brings the question: do you need anything specific to 1.3, or can we use a more inclusive "lang" version for the sake of compatibility with more dune versions?

-- Mauricio Fernández

vbmithr commented 6 years ago

We can use a more inclusive lang. Well at least it does not prevents compilation. I'm doing this.