mfrachet / cypress-audit

âš¡ Run Lighthouse and Pa11y audits directly in your E2E test suites
https://mfrachet.github.io/cypress-audit/
MIT License
352 stars 43 forks source link

Update plugin to be compatible with Cypress 10 #155

Closed admah closed 2 years ago

admah commented 2 years ago

Hello 👋 I'm writing on behalf of the Cypress DX team. We wanted to notify you that some changes may need to be made to this plugin to ensure that it works in Cypress 10.

For more information, here is our official plugin update guide.

mfrachet commented 2 years ago

Thanks for the heads-up, will take a look at it 😊

mfrachet commented 2 years ago

Updating the example to use the new API: https://github.com/mfrachet/cypress-audit/pull/156

MichaelRobsonSliide commented 2 years ago

Updating the example to use the new API: #156

Hi, is this example now complete? I'm trying to get cypress-audit working with my new framework so wondering if I can follow these changes. Thanks!

mfrachet commented 2 years ago

Hello, no it's not complete yet 😊 . I'm on vacation right now and will take care of it when I'll get back! Also, I would expect the plugin to work seamlessly by moving the configuration in the new files (e.g: cypress.config.js) and making sure the command is correctly imported.

Will update this in 2 weeks or so :)

MichaelRobsonSliide commented 2 years ago

Hello, no it's not complete yet 😊 . I'm on vacation right now and will take care of it when I'll get back! Also, I would expect the plugin to work seamlessly by moving the configuration in the new files (e.g: cypress.config.js) and making sure the command is correctly imported.

Will update this in 2 weeks or so :)

Thanks for the update. I gave it a try but I ended up getting the same error as in this other open issue when I called lighthouse or pally. Enjoy your vacation :)

mfrachet commented 2 years ago

I think it should be okay with the 2 pull requests merged :). Thanks for the reminder Admah, very much appreciate it!

Closing this issue since it should be solved 😊

dsueltenfuss commented 2 years ago

Will you be updating the npm package? The latest one showing is v1.1.0

mfrachet commented 2 years ago

You need to install @cypress-audit/ligthouse as explained in the doc, not cypress-audit.

dsueltenfuss commented 2 years ago

Thank you, I missed that