search

mfractor / mfractor-feedback

Found a bug or have a feature request for MFractor? Submit it here!
3 stars 0 forks source link

Grid row insert/delete actions often do not work #315

Open pgilhuijs opened 3 years ago

pgilhuijs commented 3 years ago

I often experience problems with inserting/deleting grid rows, one of the powerful actions of the tooling. However most of the times it is simply not working and I cannot see why. I've attached a logfile also.

Ide.2021-01-18__08-18-08.log

Installation Information

--Platform Information--
Operating System: Mac
OS: Unix
OS Service Pack: 
OS Version: Unix 19.6.0.0
--MFractor Information--
Product Name: MFractor
Product Version: 4.3.3.0
Product Variant: Visual Studio Mac
Product Variant Version: 8.7.9.9
Product SKU: MFRACTOR-VS-MAC
Commit SHA: 18c0d29f339bf4321ded3a59430f48f3019e459d
Revision: 4597
Branch: master
Date: 24/09/2020 1:07:23 AM (UTC)
Agent: Local
Installed extensions:   'FileNesting (0.1.2)', 'MFractor (4.3.3)', 'Code Coverage (1.0)', 'Refactoring Support (8.7.9)', 'Azure Functions development (8.7.9)', 'Web Project Support (8.7.9)', 'Visual Studio for Mac Tools for Unity (2.7.0.0)', 'Android Designer (16.7.0.495)', 'Test Runner (8.7.9)', 'Visual Designer Support (8.7.9)', 'Subversion core engine (8.7.9)', 'Xamarin Addins Core (8.7)', 'ILAsm Language Binding (8.7.9)', 'GTK# Visual Designer (8.7.9)', 'Razor Language Services (8.0.20200612.01)', 'NuGet Packaging (8.7.9)', 'Xamarin.Forms Previewer (16.7.0.495)', 'MonoDevelop Assembly Browser (8.7.9)', 'CSharp Language Binding (8.7.9)', 'Xamarin.Mac development (8.7)', 'Git support (8.7.9)', 'Project Web References (8.7.9)', 'Version Control Support (8.7.9)', 'NUnit support (8.7.9)', 'F# Language Binding (8.7.9)', 'Debugger support for MonoDevelop (8.7.9)', 'Mono Soft Debugger Support (8.7.9)', 'iOS development (8.7)', 'iOS Designer (16.7.0.495)', 'Text Templating (8.7.9)', 'Xamarin Ide Identity (8.7.9)', 'Forms Project Support (8.7)', 'Azure Support (8.7.9)', 'NuGet Package Management (8.7.9)', 'Mac Development (8.7)', 'XamlLanguageService (16.7.0.495)', 'Web Editors (8.3)', 'MonoDevelop Text Editor (8.7.9)', 'Azure Mobile App Service (8.7)', 'Xamarin Terminal (8.7.9)', '.NET Core Support (8.7.9)', 'Container Tools (1.0.20200521.1)', 'ConnectedServices (8.7.9)', 'Extension Developer Tools (8.7.9)', 'Performance Diagnostics of IDE (8.7.9)', 'Unit Testing core support (8.7.9)', 'ChangeLog Add-in (8.7.9)', 'JavaScript and TypeScript (8.3)', 'Xamarin Ide Extensions (8.7.9)', 'Xamarin Ide Extensions for Mac (8.7.9)', 'Regex Toolkit (8.7.9)', 'Android development (8.7)', 'MonoDevelop Mac Platform Support (8.7.9)', 'MonoDevelop Text Editor (8.7.9)', 'VsCode Debug Protocol support for MonoDevelop (8.7.9)', 'Deployment Services Core (8.7.9)', 'Mono Soft Debugger Support for ASP.NET (8.7.9)', 'Xamarin Designer (16.7.0.495)', 'Gettext Translations Support (8.7.9)', 'MonoDevelop Source Editor (8.7.9)', 'GDB Debugger Support (8.7.9)', 'MonoDevelop Hex Editor (8.7.9)', 'Makefile generation (8.7.9)', 'Xamarin Test Cloud (8.7)', 'Subversion support (8.7.9)', 'Xamarin Test Cloud - NUnit (8.7)', '.Net Core Debugger (8.7.9)', 'Xamarin Hot Reload (1.0.0.3874908)', 'Android Deploy (16.7.0.495)', 'XML Editor (8.7.9)', 'VB.NET Language Binding (8.7.9)', 'ASP.NET Core Support (8.7.9)', 'Azure DevOps Authentication Support (8.7.9)'
ravero commented 3 years ago

Hello @pgilhuijs, I'll help you on this case.

I'm evaluating your log to inspect for errors. In the meantime can you give me more details about what it's not working? Is it the code action that is not appearing or it doesn't apply the changes when you select it? Does it happens sometimes or can you provide me an example where the problems always happen? This will help us a lot on identifying and fixing the problem.

Sorry about the inconvenience.

pgilhuijs commented 3 years ago

Well, strange thing is, I’ve seen it working sometimes, sometimes not. No clue what the different was. I just tried a repro scenario and as simple as this:

<Grid VerticalOptions="CenterAndExpand">
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto"/>
    </Grid.RowDefinitions>
</Grid>

This is not working…. Logs shows: 1/21/2021 9:33:42 AM [InsertGridRowColumnGenerator.cs : warning] The provided grid does not contain the Grid.RowDefinitions property 1/21/2021 9:33:42 AM [ApplicationInsightsAnalyticsService.cs : info] User event: "Insert Grid Row And Update Elemets"

Kind regards, Patrick

On 20 Jan 2021, at 03:29, Rafael Veronezi notifications@github.com wrote:

Hello @pgilhuijs https://github.com/pgilhuijs, I'll help you on this case.

I'm evaluating your log to inspect for errors. In the meantime can you give me more details about what it's not working? Is it the code action that is not appearing or it doesn't apply the changes when you select it? Does it happens sometimes or can you provide me an example where the problems always happen? This will help us a lot on identifying and fixing the problem.

Sorry about the inconvenience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mfractor/mfractor-feedback/issues/315#issuecomment-763284960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3PIYNFFS2NGYY5RGOP6BDS2Y5Z5ANCNFSM4WINKTVQ.

ravero commented 3 years ago

Got it! Just need to clarify, does the options always appears and sometimes it doesn't work, or does the appearance of the option is intermittent too? This is important so I can check on the right place.

Sorry for inconvenience! Regards, Rafael

pgilhuijs commented 3 years ago

No problem! The menu option is shown correctly, but doesn’t always work.

Regards, Patrick

Outlook voor iOShttps://aka.ms/o0ukef downloaden

Van: Rafael Veronezi notifications@github.com Verzonden: vrijdag, januari 22, 2021 1:58 AM Aan: mfractor/mfractor-feedback CC: Patrick Gilhuijs; Mention Onderwerp: Re: [mfractor/mfractor-feedback] Grid row insert/delete actions often do not work (#315)

Got it! Just need to clarify, does the options always appears and sometimes it doesn't work, or does the appearance of the option is intermittent too? This is important so I can check on the right place.

Sorry for inconvenience! Regards, Rafael

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mfractor/mfractor-feedback/issues/315#issuecomment-765040784, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3PIYNPNFCS7Z47EIUMH3DS3DETDANCNFSM4WINKTVQ.

ravero commented 3 years ago

Hi @pgilhuijs, I've been running extensive tests and yet I couldn't reproduce your problem, I've found some inconsistent behaviors that may lead to it. I've found that the code actions runs fine when you invoke with cursor over the RowDefinition/ColumnDefinition themselves. Sometimes the options appear when invoking the menu over the Grid itself, this is where you can your problems.

Can you confirm from which part of the code you invoke the actions menu? I'll be reviewing this feature to try to eliminate this inconsistencies.

pgilhuijs commented 3 years ago

I'm actually always right clicking the row definition.

Outlook voor iOShttps://aka.ms/o0ukef downloaden

Van: Rafael Veronezi notifications@github.com Verzonden: Friday, January 22, 2021 10:56:53 PM Aan: mfractor/mfractor-feedback mfractor-feedback@noreply.github.com CC: Patrick Gilhuijs p.gilhuijs@gmail.com; Mention mention@noreply.github.com Onderwerp: Re: [mfractor/mfractor-feedback] Grid row insert/delete actions often do not work (#315)

Hi @pgilhuijshttps://github.com/pgilhuijs, I've been running extensive tests and yet I couldn't reproduce your problem, I've found some inconsistent behaviors that may lead to it. I've found that the code actions runs fine when you invoke with cursor over the RowDefinition/ColumnDefinition themselves. Sometimes the options appear when invoking the menu over the Grid itself, this is where you can your problems.

Can you confirm from which part of the code you invoke the actions menu? I'll be reviewing this feature to try to eliminate this inconsistencies.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mfractor/mfractor-feedback/issues/315#issuecomment-765707286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3PIYNHVXREIT6YUV6V53DS3HYCLANCNFSM4WINKTVQ.