search

mfractor / mfractor.github.io

Documentation for MFractor, the ultimate .NET MAUI productivity tool.
https://docs.mfractor.com
2 stars 3 forks source link

Docs #47

Closed AlexHedley closed 4 years ago

AlexHedley commented 4 years ago

Added 'Open Android Manifest' for macOS

Started work on XAML IntelliSense, needs more work.

A few typos corrected

Added Tabs

matthewrdev commented 4 years ago

Thanks for the contribution @AlexHedley.

I can see that there are additional mkdocs extensions included in your pull request. Do these extensions require additional installation and, if so, can you add instructions to the contribution guide on installing these extensions locally?

AlexHedley commented 4 years ago

@matthewrdev do we not already have PyMdown Extensions? Material for MkDocs mentions

A compatible version is always included with the theme.

Sorry if this isn't the case, I wouldn't have introduced a new dependency otherwise.

matthewrdev commented 4 years ago

@AlexHedley The tab extension elegantly solves a problem I'd been on/off trying to figure out for a while so the addition is appreciated. The new docs look good, keep it coming!

AlexHedley commented 4 years ago

Thought it was best to get reviewed now as not sure when I'll next be able to look at it, so get's the current changes added.

ravero commented 4 years ago

Hi @AlexHedley, is it ready for merge? Please confirm me so I'll proceed with the review.