mfreeborn / fastapi-sqlalchemy

Adds simple SQLAlchemy support to FastAPI
MIT License
619 stars 38 forks source link

Session.rollback are sync operation #1

Closed kataev closed 4 years ago

kataev commented 4 years ago

You call sess.rollback() in middleware, but this is sync and blocking operationб this may block loop.

mfreeborn commented 4 years ago

I'm not sure if this is an issue as such? Sqlalchemy, generally, is not async