search

mfreeborn / fastapi-sqlalchemy

Adds simple SQLAlchemy support to FastAPI
MIT License
594 stars 34 forks source link

ERROR: fastapi-sqlalchemy 0.1.0 has requirement starlette<=0.12.9,>=0.12.9, but you'll have starlette 0.13.4 which is incompatible. #14

Closed cnly1987 closed 3 years ago

cnly1987 commented 4 years ago

if i install starlette<=0.12.9 then fastapi error: from starlette.concurrency import run_until_first_complete # noqa ImportError: cannot import name 'run_until_first_complete'

mfreeborn commented 4 years ago

Thanks for raising this. Can I first ask you to update to the latest version of fastapi-sqlalchemy (0.1.4 at time of writing) and then tell me if you get the same error? Looking back, I think I messed up the Starlette version requirements in 0.1.0.

cnly1987 commented 4 years ago

Thanks for raising this. Can I first ask you to update to the latest version of fastapi-sqlalchemy (0.1.4 at time of writing) and then tell me if you get the same error? Looking back, I think I messed up the Starlette version requirements in 0.1.0.

yeah!
fastapi's lastest-version depends Starlette=0.13.4
but the fastapi-sqlalchemy_0.1.0 depends Starlette=0.12.9 Starlette(0.13.4) no module named 'run_until_first_complete'

mfreeborn commented 4 years ago

Hi @cnly1987 - can I just check why you closed this? If this is resolved, then I don't need to look into it, otherwise I will look into it.

nahid002345 commented 4 years ago

@mfreeborn I have installed the latest version of fastapi-sqlalchemy, but still it's starlette version error!

mfreeborn commented 4 years ago

Reopened and will fix tomorrow. Thanks for the feedback.

mfreeborn commented 4 years ago

@nahid002345 I'm struggling to reproduce on my end. I've done a fresh install of fastapi and fastapi-sqlalchemy and they seem to work fine together. Fastapi-sqlalchemy requires starlette >= 0.12.9, which is compatible with fastapi's requirement starlette == 0.13.4.

If you type pip list, what is the output?

mfreeborn commented 3 years ago

No responses and unable to reproduce. Closing.