mfreiholz / iF.SVNAdmin

Web-based GUI to manage Subversion repositories and User/Group permissions (+LDAP support)
http://svnadmin.insanefactory.com/
GNU General Public License v2.0
350 stars 153 forks source link

add missing functions to LdapUserViewProvider #137

Open tbenk opened 7 years ago

tbenk commented 7 years ago

LDAP does not work out of the box for me, i had to add the following three dummy functions to get it working:

Error message:

[Tue Aug 29 05:32:21.674119 2017] [:error] [pid 25831] [client 77.20.128.83:7317] PHP Fatal error: Class svnadmin\providers\ldap\LdapUserViewProvider contains 3 abstract methods and must therefore be declared abstract or implement the remaining methods (svnadmin\core\interfaces\IGroupViewProvider::getGroupsOfSubgroup, svnadmin\core\interfaces\IGroupViewProvider::getSubgroupsOfGroup, svnadmin\core\interfaces\IGroupViewProvider::isSubgroupInGroup) in /srv/www/htdocs/svnadmin/classes/providers/ldap/LdapUserViewProvider.class.php on line 22

Rincewind34 commented 2 years ago

Hey there, in case anybody else does have issues with ldap: this implementation is not correct and DOES NOT work. LDAP itself doesn't support nested groups (or inheritance) so those methods can be implemented correctly fairly easily:

Hope this is cutting an hour of searching from anyone who tries it next ;)