mfreiholz / persistent_login

Provides a "Keep me logged in" aka "Remember Me" functionality for Roundcube.
78 stars 49 forks source link

persistent_login no more works with new beta version 1.3.0 of Roundcube #38

Closed Melkin1968 closed 7 years ago

Melkin1968 commented 7 years ago

Hello,

it seems as persistent_login plugin no more works with new beta version 1.3.0 of Roundcube. Could you please modify persistent_login plugin for new Roundcube version?

Thank you a lot!

mfreiholz commented 7 years ago

Thank you. I will take care of it.

fearworksmedia commented 7 years ago

Any update on this issue?

I too have found the same problem - just wondering if there's likely to be an update soon or if you can point me in the right direction for patching it myself, just to get it working again for now?

Thanks :)

mfreiholz commented 7 years ago

Currently working on it :)

fearworksmedia commented 7 years ago

Hi,

Thanks for the update, but for me it still doesn't appear to be working correctly on version 1.3 beta.

I have tried running it with all other plugins disabled, and with the $config['session_lifetime'] variable set to 1 minute just for testing purposes.

It seems to be very inconsistent - sometimes it will remember me and other times I get told my session has expired. I have primarily tested with Google Chrome on more than one PC, with all cookies and history cleared before testing.

If you would like a test account on my server, please let me know!

Thanks.

mfreiholz commented 7 years ago

All I can think of right now is, that It is sometimes a problem when you have "remember last session" in chrome active.

What exactly doesnt work, exact use case please. Which configuration are you using, with auth token or simple cookie solution?

Sent from mobile phone.

Am 19.03.2017 14:24 schrieb "fearworksmedia" notifications@github.com:

Hi,

Thanks for the update, but for me it still doesn't appear to be working correctly on version 1.3 beta.

I have tried running it with all other plugins disabled, and with the $config['session_lifetime'] variable set to 1 minute just for testing purposes.

It seems to be very inconsistent - sometimes it will remember me and other times I get told my session has expired. I have primarily tested with Google Chrome on more than one PC, with all cookies and history cleared before testing.

If you would like a test account on my server, please let me know!

Thanks.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/mfreiholz/persistent_login/issues/38#issuecomment-287616474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxZqQx2UsBHHJnWBJCii9eQnpgAN7Odks5rnSyLgaJpZM4LtRXs .

fearworksmedia commented 7 years ago

Hi,

I will keep testing to see if I can work out how to recreate it and then let you know.

Thanks.

Kind Regards,

Keith Fairley

On 19.03.2017 2:12 pm, Manuel Freiholz wrote:

All I can think of right now is, that It is sometimes a problem when you have "remember last session" in chrome active.

What exactly doesnt work, exact use case please. Which configuration are you using, with auth token or simple cookie solution?

Sent from mobile phone.

Am 19.03.2017 14:24 schrieb "fearworksmedia" notifications@github.com:

Hi,

Thanks for the update, but for me it still doesn't appear to be working correctly on version 1.3 beta.

I have tried running it with all other plugins disabled, and with the $config['session_lifetime'] variable set to 1 minute just for testing purposes.

It seems to be very inconsistent - sometimes it will remember me and other times I get told my session has expired. I have primarily tested with Google Chrome on more than one PC, with all cookies and history cleared before testing.

If you would like a test account on my server, please let me know!

Thanks.

-- You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/mfreiholz/persistent_login/issues/38#issuecomment-287616474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxZqQx2UsBHHJnWBJCii9eQnpgAN7Odks5rnSyLgaJpZM4LtRXs .

-- You are receiving this because you commented. Reply to this email directly, view it on GitHub [1], or mute the thread [2].

Links:

[1] https://github.com/mfreiholz/persistent_login/issues/38#issuecomment-287619366 [2] https://github.com/notifications/unsubscribe-auth/AGWqDfnSsWnQxGbTCaP4khrKdnZ0xo0-ks5rnTfWgaJpZM4LtRXs