mfridman / tparse

CLI tool for summarizing go test output. Pipe friendly. CI/CD friendly.
MIT License
998 stars 22 forks source link

Don't group slow tests #35

Closed egonelbre closed 5 years ago

egonelbre commented 5 years ago

This allows -slow 5 to limit output to only 5 slowest tests, or -slow -1 to all slowest tests.

Fixes #34

mfridman commented 5 years ago

Thank you for submitting a PR. 🎉

I think you're right, more often users would want n number of slowest tests regardless of pkg, so let's give this a try.


I think in the future it'd be nice to consolidate the logic, e.g.,

then check if slow is available and do some logic relating to that, otherwise iterate over all and add "line break" whenever pkg changes.

egonelbre commented 5 years ago

For consolidating logic, I was trying to avoid too large refactoring since you have the path towards v1 issue.

mfridman commented 5 years ago

Awesome. Thanks for contribution.