mfthomps / Labtainers

Labtainers: A Docker-based cyber lab framework
https://nps.edu/web/c3o/labtainers
272 stars 68 forks source link

Couldn't grade wireshark-intro test #18

Open olberger opened 5 years ago

olberger commented 5 years ago

I've just tested the wireshark-intro and tried to grade my own test... but got :

student@Labtainer-VM:~/labtainer/labtainer-instructor$ gradelab wireshark-intro
pulling labtainer.grader from mfthomps
Done with pull
[2019-06-04 00:55:56,785 - ERROR : gradelab:207 - autoGrade() ] trouble with docker exec wireshark-intro-igrader bash -c 'su - instructor -c "cd;.local/bin/instructor.py"'
Labname wireshark-intro

Student              | wiresharkextrac |
==================== | =============== |
olivier.berger_at_te |                 |
What is automatically assessed for this lab:

    wiresharkextractOK: used wireshark to extract the desired packets

Dunno what's wrong exactly

mfthomps commented 5 years ago

Thanks for the report. Try using update-labtainer.sh to make sure it is the latest version. That lab's instructions need work to clarify the filename must be invalidpassword.pcap (no pcapng suffix) -- or fixed to accept either. And the instructions need guidance on how to save selected packets. Let me know if the update does not work. I'd be happy to look at the results zip file from the lab. --Mike

On Tue, Jun 4, 2019 at 1:01 AM Olivier Berger notifications@github.com wrote:

I've just tested the wireshark-intro and tried to grade my own test... but got :

student@Labtainer-VM:~/labtainer/labtainer-instructor$ gradelab wireshark-intro pulling labtainer.grader from mfthomps Done with pull [2019-06-04 00:55:56,785 - ERROR : gradelab:207 - autoGrade() ] trouble with docker exec wireshark-intro-igrader bash -c 'su - instructor -c "cd;.local/bin/instructor.py"' Labname wireshark-intro

Student | wiresharkextrac | ==================== | =============== | olivier.berger_at_te | | What is automatically assessed for this lab:

wiresharkextractOK: used wireshark to extract the desired packets

Dunno what's wrong exactly

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mfthomps/Labtainers/issues/18?email_source=notifications&email_token=AFCIJWZIBBWM5F4RSPUJXUDPYYOPBA5CNFSM4HSZYGRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXOWZDA, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCIJW4IC2657BR66TLEDILPYYOPBANCNFSM4HSZYGRA .

olberger commented 5 years ago

I had just updated with the script...

My bad :

zipinfo olivier.berger_at_telecom-sudparis.eu.wireshark-intro=wireshark-intro.wireshark-intro.student.zip
Archive:  olivier.berger_at_telecom-sudparis.eu.wireshark-intro=wireshark-intro.wireshark-intro.student.zip
Zip file size: 19861 bytes, number of entries: 14
-rw-r--r--  2.0 unx     3920 b- defN 19-Jun-04 07:38 .bashrc
-rw-r--r--  2.0 unx      980 b- defN 19-Jun-04 07:38 .profile
-rw-r--r--  2.0 unx        0 b- defN 19-Jun-04 07:38 .sudo_as_admin_successful
-rw-------  2.0 unx       11 b- defN 19-Jun-04 07:39 .bash_history
-rw-rw-r--  2.0 unx      120 b- defN 19-Jun-04 07:45 invqlidpqsszord.pcap
-rw-rw-r--  2.0 unx    35584 b- defN 19-Jun-04 07:38 telnet.pcap
-rw-rw-r--  2.0 unx      477 b- defN 19-Jun-04 07:45 .config/QtProject.conf
-rw-rw-r--  2.0 unx     2236 b- defN 19-Jun-04 07:54 .config/wireshark/recent
-rw-rw-r--  2.0 unx     1629 b- defN 19-Jun-04 07:54 .config/wireshark/recent_common
-rw-r--r--  2.0 unx       33 b- defN 19-Jun-04 07:38 .local/.seed
-rw-r--r--  2.0 unx       16 b- defN 19-Jun-04 07:38 .local/.labname
-rw-r--r--  2.0 unx       33 b- defN 19-Jun-04 07:38 .local/.watermark
-rw-r--r--  2.0 unx       35 b- defN 19-Jun-04 07:38 .local/.email
-rwxrwxr-x  2.0 unx      202 b- defN 19-Jun-04 07:38 .local/bin/fixlocal.sh
14 files, 45276 bytes uncompressed, 18295 bytes compressed:  59.6%

Guess who had a qwerty settings with an azerty keyboard ? ;)

Well... maybe the grading script could just check whether there's only one (new) .pcap file and use it ?

olberger commented 5 years ago

I started over, and this time have the correct file there

$ zipinfo olivier.berger_at_telecom-sudparis.eu.wireshark-intro=wireshark-intro.wireshark-intro.student.zip
Archive:  olivier.berger_at_telecom-sudparis.eu.wireshark-intro=wireshark-intro.wireshark-intro.student.zip
Zip file size: 20086 bytes, number of entries: 15
-rw-r--r--  2.0 unx     3920 b- defN 19-Jun-04 07:38 .bashrc
-rw-r--r--  2.0 unx      980 b- defN 19-Jun-04 07:38 .profile
-rw-r--r--  2.0 unx        0 b- defN 19-Jun-04 07:38 .sudo_as_admin_successful
-rw-------  2.0 unx       11 b- defN 19-Jun-04 07:39 .bash_history
-rw-rw-r--  2.0 unx      120 b- defN 19-Jun-04 07:45 invqlidpqsszord.pcap
-rw-rw-r--  2.0 unx      120 b- defN 19-Jun-04 16:51 invalidpassword.pcap
-rw-rw-r--  2.0 unx    35584 b- defN 19-Jun-04 07:38 telnet.pcap
-rw-rw-r--  2.0 unx      477 b- defN 19-Jun-04 16:51 .config/QtProject.conf
-rw-rw-r--  2.0 unx     2244 b- defN 19-Jun-04 16:51 .config/wireshark/recent
-rw-rw-r--  2.0 unx     1627 b- defN 19-Jun-04 16:51 .config/wireshark/recent_common
-rw-r--r--  2.0 unx       33 b- defN 19-Jun-04 07:38 .local/.seed
-rw-r--r--  2.0 unx       16 b- defN 19-Jun-04 07:38 .local/.labname
-rw-r--r--  2.0 unx       33 b- defN 19-Jun-04 07:38 .local/.watermark
-rw-r--r--  2.0 unx       35 b- defN 19-Jun-04 07:38 .local/.email
-rwxrwxr-x  2.0 unx      202 b- defN 19-Jun-04 07:38 .local/bin/fixlocal.sh
15 files, 45402 bytes uncompressed, 18404 bytes compressed:  59.5%

But still the same error:

$ gradelab wireshark-intro
[2019-06-04 09:51:57,405 - ERROR : gradelab:207 - autoGrade() ] trouble with docker exec wireshark-intro-igrader bash -c 'su - instructor -c "cd;.local/bin/instructor.py"'
Labname wireshark-intro

Student              | wiresharkextrac |
==================== | =============== |
olivier.berger_at_te |                 |
What is automatically assessed for this lab:

    wiresharkextractOK: used wireshark to extract the desired packets

Looks like the grading container has a problem :-/

mfthomps commented 5 years ago

If you get a chance, please retest after doing an update-labtainer. I'm unable to duplicate the problem. Try using gradelab -r to ensure you get a fresh grader. Sorry for the slow response. Thanks. --Mike