mfts / papermark

Papermark is the open-source DocSend alternative with built-in analytics and custom domains.
https://papermark.io
GNU Affero General Public License v3.0
5.66k stars 759 forks source link

[🕹ī¸] BUG: Guest page refresh problem #697

Open ykburda opened 1 month ago

ykburda commented 1 month ago

What side quest or challenge are you solving?

Bug

Points

?

Description

Hi, I have seen a major bug in guest page. Here the steps. As member: 1- Use dataroom group link and see what is inside As admin: 2- Add a folder to dataroom 3- move file to this folder As member: 4- refresh or relogin link. Bug: There is no refreshed page.

Provide proof that you've completed the task

We should see latest situation.

AshishViradiya153 commented 1 month ago

Thanks for spotting that one. @ykburda

mfts commented 1 month ago

Really good spot, @ykburda

/award 100

oss-gg[bot] commented 1 month ago

Awarding ykburda: 100 points 🕹ī¸ Well done! Check out your new contribution on oss.gg/ykburda

mfts commented 1 month ago

Basically, when the admin adds a new document/folder to an existing dataroom, we need to check the group permissions.

There should be an opt-in to let users choose if it should apply to the same group permission that are already set.

Status Quo: when a permission is set on a dataroom for particular files, then any additional files are not viewable if added afterwards. CleanShot 2024-10-09 at 11 57 46@2x

Future: when a new document is added, then I want to have the option to opt-in to set permissions for this new document.

AshishViradiya153 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

AshishViradiya153 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @AshishViradiya153! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

ykburda commented 1 month ago

But in my sample i'm just adding new folder and moving file to that folder etc. If i don't save permissions all again it's showing old version. I've renewed permissions disable-enable and affected after sometime. This is not nice. It should somehow refresh without touching permissions etc.

adkibhaskar commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 1 month ago

@AshishViradiya153, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

alokesh-git commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

hiralvavadiya commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

Anky9972 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

arpan595jain commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

pikachusensei commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 1 month ago

@AshishViradiya153, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

nil-frontend commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

Ashutoshdas-dev commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

PRATHAMESH75 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

AndrewHamal commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

pikachusensei commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @pikachusensei! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

AshishViradiya153 commented 1 month ago

@pikachusensei I'm still working on this issue. I've already finished it, and the PR is currently under review.

oss-gg[bot] commented 1 month ago

@pikachusensei, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Nithin-532 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 1 month ago

@pikachusensei has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

PRATHAMESH75 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @PRATHAMESH75! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

PRATHAMESH75 commented 1 month ago

@ykburda could we have a talk regarding this bug?

oss-gg[bot] commented 4 weeks ago

@PRATHAMESH75, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

oss-gg[bot] commented 4 weeks ago

@PRATHAMESH75 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

Nithin-532 commented 4 weeks ago

/assign

oss-gg[bot] commented 4 weeks ago

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

adot-7 commented 3 weeks ago

/assign

oss-gg[bot] commented 3 weeks ago

Assigned to @akash-2004! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

oss-gg[bot] commented 3 weeks ago

@akash-2004, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

oss-gg[bot] commented 3 weeks ago

@akash-2004 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.