mfts / papermark

Papermark is the open-source DocSend alternative with built-in analytics and custom domains.
https://papermark.io
GNU Affero General Public License v3.0
3.79k stars 556 forks source link

[🕹️]BUG Editing Link screen scrollbar #702

Open ykburda opened 3 days ago

ykburda commented 3 days ago

What side quest or challenge are you solving?

Bug

Points

?

Description

Link editing page doesn't fit to screen. There should be scrollbar. image

Provide proof that you've completed the task

?

AshishViradiya153 commented 3 days ago

which page exactly is it happening ? @ykburda

ykburda commented 3 days ago

image

AshishViradiya153 commented 3 days ago

I tried everything to replicate this, but based on the code, we always have a scroll no matter how much it expands. The strange thing in the first image is the space on the right side, which we don’t have in the edit link sidebar.

AshishViradiya153 commented 3 days ago

@ykburda Could you please add a short video if possible, so I can take a closer look? I will add more space at the bottom so that the last one appears in the middle instead of to much at the bottom.

ykburda commented 3 days ago

It's not screen fit problem. When i click to edit link button. It's opening a popup right side of window. It has many fields and i can not scroll because it doesn't show scrollbar.It's somehow possible with pagedown or down keyboard button.

DeepaPrasanna commented 3 days ago

hey @AshishViradiya153 you should first assign yourself and then link a PR

AshishViradiya153 commented 3 days ago

@ykburda It's not a bug. There are two dropdown fields that should close after opening if the user starts scrolling or interacting with something else.

ykburda commented 3 days ago

Hi It is sliding in the mobile. There are many options in the editing page. It is not shown and stays hidden. Somehow slide required with scrollbar in desktop

AshishViradiya153 commented 3 days ago

Okay i will recheck ui.

HimanshuGarg5480 commented 2 days ago

/assign

oss-gg[bot] commented 2 days ago

Assigned to @HimanshuGarg5480! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

sundeeep commented 2 days ago

/assign

oss-gg[bot] commented 2 days ago

This issue is already assigned to another person. Please find more issues here.

Kartikgupta666 commented 1 day ago

/assign

oss-gg[bot] commented 1 day ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 20 hours ago

@HimanshuGarg5480, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

OptimisticTech-Amber commented 12 hours ago

/assign

oss-gg[bot] commented 12 hours ago

This issue is already assigned to another person. Please find more issues here.